Welcome, Guest
Username: Password: Remember me

TOPIC: dstar variable definition missing

dstar variable definition missing 4 years 1 week ago #37166

  • nikos
  • nikos's Avatar
  • OFFLINE
  • Junior Boarder
  • Posts: 35
  • Thank you received: 1
Dear community

because of my research project on quality of large Fortran models, I noticed that in function cvsp_alt.f , since versions 8 have become available
the local variable DSTAR is used in case 3 *(VAN RIJN 1993 formula)
but it is not initialized. In particular the

DSTAR = D50*((XMVS/XMVE-1.D0)*G/(VCE**2))**(1./3.)

is not there. I believe this happened by human mistake. Or not?

Gfortran usually assigns value 0 to non initialized variables. Other compilers unfortunately not.


Many thanks and regards,
Nikos
The administrator has disabled public write access.

dstar variable definition missing 4 years 1 week ago #37168

  • kopmann
  • kopmann's Avatar
  • OFFLINE
  • Senior Boarder
  • Posts: 106
  • Thank you received: 65
Dear Nikos,

Many thanks for reporting. We also found the mistake lately. It is corrected in the trunk version and will be correct in the coming soon (December) new version v8p2.

Just for your information: new developments will be in the module gaia instead of sisyphe.


Best regards,
Rebekka
The administrator has disabled public write access.
Moderators: Pablo, pavans

The open TELEMAC-MASCARET template for Joomla!2.5, the HTML 4 version.