Welcome, Guest
Username: Password: Remember me
  • Page:
  • 1
  • 2

TOPIC: How to raise the maximum number of sources in t3d

How to raise the maximum number of sources in t3d 11 months 3 days ago #43837

  • colinemathias
  • colinemathias's Avatar
  • OFFLINE
  • Fresh Boarder
  • Posts: 18
  • Thank you received: 1
Hello Chi-Tuan,

Here is my steering file. The error I get is
*********************************************
 ADRESS GREATER THAN NMAX =          300
 TOO MANY VALUES OF TYPE :            2  DECLARED.
 STOP OF DAMOCLES AT KEY-WORD NUMBER:           36
 *********************************************

even after modifying MAXKEYWORD in declarations_special.F. I tried modifying it in a copy of the file, that I then specify in FORTRAN FILE, I also tried modifying it directly in the telemac files. I think my problem is that I cannot clean compile TELEMAC (this is why I originally posted this problem here : opentelemac.org/index.php/kunena/2-windo...-automatic-installer)

I'm aware of the limit of 72 columns, so I splitted the definition of my 200+ sources on several lines.

Thank you,

Coline
Attachments:
The administrator has disabled public write access.

How to raise the maximum number of sources in t3d 11 months 3 days ago #43840

  • pham
  • pham's Avatar
  • OFFLINE
  • Administrator
  • Posts: 1559
  • Thank you received: 602
Hello Coline,

Indeed, you do not post this topic in the right section and as a rule of this forum, do not double (or most) post the same question in different topics.

Anyway, for your suggestion to move ; from the end of line to the beginning, I cannot see why you have to do so. I have swaped from beginning to end of your steering file with another geometry + boundary conditions files and it runs correctly.

For your issue of increasing MAXKEYWORD, I have changed its value in $HOMETEL/sources/special/declarations_special.F
      ! Max number of keywords
      INTEGER, PARAMETER :: MAXKEYWORD = 3000

Then I have run compile_telemac.py --clean

I also have had to declare as many values for the keyword WATER DISCHARGE OF SOURCES as the number of values for the 2 keywords ABSCISSAE OF SOURCES + ORDINATES OF SOURCES.

In that case, the computation starts to run correctly:
================================================================================
ITERATION 0 TIME: 0.0000 S
PRERES: MAXIMUM COURANT NUMBER: 0.000000
TELEMAC2D INITIALIZED
USING STREAMLINE VERSION MAIN FOR CHARACTERISTICS
PROSOU : IN CARTESIAN COORDINATES, THE CORIOLIS
PARAMETER IS READ IN THE STEERING FILE
IT IS THE KEY WORD 'CORIOLIS
COEFFICIENT', IT IS UNIFORM IN SPACE

Perhaps you have to change something in your way to install TELEMAC and not starting from the automatic installer as you change something.
You can have a look here:
gitlab.pam-retd.fr/otm/wintel

I cannot help you more.

Hope this helps,

Chi-Tuan
The administrator has disabled public write access.
The following user(s) said Thank You: colinemathias

How to raise the maximum number of sources in t3d 9 months 1 week ago #44155

  • nicogodet
  • nicogodet's Avatar
  • OFFLINE
  • Expert Boarder
  • Posts: 157
  • Thank you received: 39
Hi Pham,

I ran into this issue today and I wondered if this value (MAXKEYWORD = 300 by default) could be a keyword that override this value instead of an harcoded value ?
It would be okay if a user fortran of declaration_special.F works but that's not the case (I tried and MAXKEYWORD remains 300).

As you can define `MAXIMUM NUMBER OF SOURCES`, user would expect to increase MAXKEYWORD also if they define a huge number of sources.

Regards,
The administrator has disabled public write access.

How to raise the maximum number of sources in t3d 9 months 1 week ago #44161

  • pham
  • pham's Avatar
  • OFFLINE
  • Administrator
  • Posts: 1559
  • Thank you received: 602
Hello nicogodet,

My first understanding of the source code for this part leads me to say it is not as easy as you could think.

Currently, the arrays to store keywords (MOTINT, MOTCAR, MOTREA, MOTLOG etc.) should be dimensioned before reading the keywords.

Another issue is that variable MAXKEYWORD is common to every module.

To be discussed at least with some colleagues of mine.

FYI if you change the value of a PARAMETER, you have to recompile the whole system as if you change the allocation of arrays (in POINT_... subroutine).

Chi-Tuan
The administrator has disabled public write access.

How to raise the maximum number of sources in t3d 9 months 1 week ago #44172

Hello,

I have the same problem with telemac 2d. I need to simulate a large number of algae classes.
I had the same error caused by MAXKEYWORD, after modifying this parameter another error message appeared and it was impossible to start the calculation.
I understood that there would be an array limit.
Do you have any clues? Is there a way to overcome these limitations?

Best regards,

Mathys
The administrator has disabled public write access.

How to raise the maximum number of sources in t3d 9 months 1 week ago #44173

  • c.coulet
  • c.coulet's Avatar
  • OFFLINE
  • Moderator
  • Posts: 3722
  • Thank you received: 1031
Hi
As Chi-Tuan already indicate, changing maxkeyword value implies to have a full recompilation of the whole system...

By the way, the problem occurs when you have a great number of parameters to enter in the steering file. You could also bypass this problem by modifying lecdon_xxx to directly enter the parameters instead of reading the steering file...
This is a little bit more complex as you should modify fortran file but this is more flexible and not managed by maxkeyword size...
Hope this helps
Christophe
The administrator has disabled public write access.

How to raise the maximum number of sources in t3d 9 months 1 week ago #44174

I know, I've already recompiled. I'll have a look at the lecdon file, that's good to know!
I hope to be able to manage the algae class parameters there.
Thank you !
The administrator has disabled public write access.

How to raise the maximum number of sources in t3d 6 months 3 weeks ago #44671

  • Sunflower
  • Sunflower's Avatar
  • OFFLINE
  • Fresh Boarder
  • Posts: 17
  • Thank you received: 1
Hi
Could you tell me how to recompile?I have encountered barriers

Thanks
The administrator has disabled public write access.

How to raise the maximum number of sources in t3d 6 months 3 weeks ago #44672

  • colinemathias
  • colinemathias's Avatar
  • OFFLINE
  • Fresh Boarder
  • Posts: 18
  • Thank you received: 1
Hello sunflower,


To recompile (if you are using Windows), you need to run in a console:
C:\TELEMAC\configs\pysource.gnu.bat
(replace "C:\TELEMAC" with your path to TELEMAC installation), then

run compile_telemac.py --clean

Hope this helps,
Coline
The administrator has disabled public write access.
  • Page:
  • 1
  • 2
Moderators: pham

The open TELEMAC-MASCARET template for Joomla!2.5, the HTML 4 version.