New output variable

System Modules TOMAWAC
1

Hello

i’d like to add two new output terms in TOMAWAC. I followed the steps of the following topic.

http://www.opentelemac.org/index.php/community-old/forum4/19-tomawac/2245-library-modifications-in-tomawac

As I add my two variables, I get the following error concerning the maximal dimension of the array containing the output variables:

“Fortran runtime error: Index ‘36’ of dimension 1 of array ‘texte’ above upper bound of 35”

If I change the upper bound of 35 (MAXVAR) I get other compiling errors.

How can I fix this?

Thanks in advance

[name removed]

2

Did you make a full clean compilation after changing maxvar?

3

I’m sorry but I don’t know what you mean with a “full clean compilation” and how I should do it.

I managed to replace two other variables with the ones I want, but I would still like to add them as new variables…

4

Hi

You should compile Telemac again with --clean option in order to make a full compilation which will take in account the change of Maxvar in all subroutines

Hope this helps

5

Hello

I don’t think that will make any difference. I change MAXVAR in a fortran file (in a windows folder) which I specify in my steering file. I’m running TELEMAC on bash on Ubuntu on my windows computer. Compiling wouldn’t take this new value into account as the source for compiling would stay the same because declarations_tomawac won’t change on ubuntu.

I hope this is clear to you…

Is this actually the way to add new variables to the output or is there another way to do it?

6

Hi

Changing a module file like declarations_tomawac.f is not allowed in a user fortran file!

This is not specific to telemac! This is a general rule for fortran compilation

Doing such manipulation and partial compilation will lead to segmentation fault or similar problems which are not tricky to debug…

You should change such files in the original source and compile again

Regards

7

Hi

okay, thanks. I’ll try to change the original source.

Another small question: I defined a new subroutine and changed some input and output of some other subroutines. According to these changes, I adapted interface_tomawac in my fortran file. I didn’t get any errors running a test, can I assume that everything went fine or should I also change interface_tomawac in the original source?

8

Hi

You should also change interface_tomawac in the original source.

This is the same kind of problem as declarations_tomawac.

There is no compilation error as you compile only the modified sources and they are consistent and you link with a library without no other verification.

But there could be some problem if non modified source file try to call a modified subroutine…

Regards