open TELEMAC-MASCARET The mathematically superior suite of solvers

Hi everyone,
In the last opentelemac V7P1, MAXKEY is set to 400. I can increase it until 1500 and everythings work well however telemac2d crash for MAXKEY=2000. Could you explain to me why telemac2d behave like that?
Is there a limit for MAXKEY ?
As MAXKEY defines the maximum size of the arrays where TELEMAC store the inputs (array of characters, array for reals, ...) I don't believe such limit do exist.
Any remark or suggestion is welcome
With regards

Hello,

Yes, after a quick look, I see no reason why it should crash. There are several arrays of strings with 144 characters that are allocated with the size MAXKEY (you say MAXKEY, I see MAXKEYWORD in the trunk...), but well it is hardly a reason to have too much memory allocation, so it would be interesting to know where it crashes in your case, and maybe also if you recompile all the system with a --clean after changing this parameter, if not it could be that some modules keep the old value...

With best regards,

Jean-Michel Hervouet

Hello Dear JMH,
I thank you first for the remark you gave to me.
I change the MAXKEY in declarations_telemac2d.f cause I have 646 sources points with UTM coordinates. I use the following to recompile telemac
compileTELEMAC.py -m "clean system -dredgesim" modules:update telemac2d
or sometimes :
compileTELEMAC.py -m "clean system -dredgesim"

Once I run a simulation, only 5 secondes and I get this :
- runcode fail
- out_telemac2d.exe a cessé de fonctionner : un problème fait que le programme a cessé de fonctionner correctement. Windows va fermer ce programme et vous indique si une solution est disponible.

If I decide to increase maxkey, is there something I miss besides changing the value of maxkey in declarations_telemac2d.f and recompiling the entire Telemac system.
With best regards

Hello Mourad

you have to compile just with compileTELEMAC.py (no need fot --clean or other options)
Otherwise, you can add the edited routine to you fortran user file. This option will spare you from a full compilation.

with my best regards

Riadh

Thanks Riadh fot your support
Actually one month ago I tried many options. In my fortran file I added declarations_telemac2d.f and debsce.f but it did not work. It seems lile many subroutine use MAXKEY : this is why I have to re-compile TELEMAC or at least telemac2d before any use

Without the oprion "-clean", no compilation can be done. It's like telemac finds everything compiled yet. Finally this option did not work too.
Ayway, it seems like even we can change the maxkey value telemac crash maybe because of a maximum limit defined somewhere.
Regards

Just to be sure, it option --clean, not -clean.

JMH

Thank you Mr Hervouet for the support,
I have a discussion in this forum about how to right compile TELEMAC. I use what Mr Coulet suggested to me, I mean this : compileTELEMAC.py -m "clean system -dredgesim"
And it work fine. The probleme is not compilign after changing some subroutines.

With no change in maxkey (MAXKEY=400) telemac2d works fine if the number of sources is about 150. I increased maxkey to 1000, its works too but until 200 sources. I increased maxkey again (MAXKEY=1500), now I can model 300 sources. But my purpose is 646 sources with UTM coordinates. Now if I increase MAXKEY beyond 1500, compilation is then well done but simulation crash (cf my first post in the top). I changed debsce.f to receive more than 99 sources (now we can model until 999 sources), but why telemac2d crash. It seems like the MAXKEY have a such a limit defined somewhere (not only in declarations_telemac2d.f)
Regards

Hello,

Could you try to run your computation with TELEMAC compiled in debug mode (there are examples in configs directory (basically for gfortran these options: -g -fbounds-check -Wall -fbacktrace) and as Jean-Michel suggested post the full error message on the forum?

Best regards,

Hello,
Thanks for your remark, even I still not get what you mean by that.
In the configs directory I have 12 cfg files but I use only this : systel_v7p1.cfg
As I have to recompile telemac from time to time and because I don't have intel compiler then I Highlighted all ifor rows as comments. Please see the attached.
In this cfg file rows dealing with gfortran scalar debud start from the row 63,
Have I to add " -g -fbounds-check -Wall -fbacktrace " somewhere after the row 63?
Regards

Hello,

The installation procedure is documented here: opentelemac.org/index.php/documentation/...rocedure-with-python

You must use "win7gforsdbg" configuration. Unfortunately there is a mistake in your .cfg (in bolt).

Regards,

# _____ _________________________________
# ____/ windows 7 gfortran scalar debug /________________________________/
[win7gforsdbg]
#
cmd_obj: gfortran -c -g -fbounds-check -Wall -fbacktrace -fopenmp -fconvert=big-endian -frecord-marker=4 <mods> <incs> <f95name>
cmd_lib: ar cru <libname> <objs>
cmd_exe: gfortran -fopenmp -fconvert=big-endian -frecord-marker=4 -v -lm -o <exename> <objs> <libs>
#
mods_all: -I <config>
#
sfx_obj: .o