Welcome, Guest
Username: Password: Remember me

TOPIC: [FEATURE] Add check of time series duration during initialisation

[FEATURE] Add check of time series duration during initialisation 1 year 11 months ago #41654

  • nicogodet
  • nicogodet's Avatar
  • OFFLINE
  • Expert Boarder
  • Posts: 157
  • Thank you received: 39
Dear devs,

It would be nice to add a check on time series (like liquid boundary) and total duration.
It would avoid a crash because of user error and wouldn't take too much initialisation time
T=   200701.00000000000       OUT OF RANGE
 OF THE FILE OF LIQUID BOUNDARIES
 NUMBER OF LINES :          224
 SOME COMPILERS REQUIRE AN
 EMPTY LINE AT THE END OF THE FILE

I know this is a user mistake (and I should pay more attention) put crash during init is better than crash after possible hours of simulation...

Regards,
The administrator has disabled public write access.

[FEATURE] Add check of time series duration during initialisation 1 year 11 months ago #41655

  • c.coulet
  • c.coulet's Avatar
  • OFFLINE
  • Moderator
  • Posts: 3722
  • Thank you received: 1031
Hi
You're right but I think this is more a pre-treatment check that could be generalized to all modules.
Then this could be done more at the python level...
Feel free to propose a solution that could be integrated in the study management

Kind regards
Christophe
The administrator has disabled public write access.

[FEATURE] Add check of time series duration during initialisation 1 year 11 months ago #41659

  • nicogodet
  • nicogodet's Avatar
  • OFFLINE
  • Expert Boarder
  • Posts: 157
  • Thank you received: 39
In case, I find some times (not likely...), I would put the check function in gitlab.pam-retd.fr/otm/telemac-mascaret/...execution/process.py and call it from gitlab.pam-retd.fr/otm/telemac-mascaret/...3/execution/study.py

Is it ok ?
The administrator has disabled public write access.

[FEATURE] Add check of time series duration during initialisation 1 year 11 months ago #41689

  • Romero64
  • Romero64's Avatar
  • OFFLINE
  • Junior Boarder
  • Posts: 40
  • Thank you received: 1
Hello!
How did you manage to solve this problem? I'm facing the same warning.
Thank you.
The administrator has disabled public write access.

[FEATURE] Add check of time series duration during initialisation 1 year 11 months ago #41690

  • c.coulet
  • c.coulet's Avatar
  • OFFLINE
  • Moderator
  • Posts: 3722
  • Thank you received: 1031
You should just check that you liquid boundary file as an ending time that excess the simulation duration...
Christophe
The administrator has disabled public write access.
The following user(s) said Thank You: Romero64

[FEATURE] Add check of time series duration during initialisation 1 year 11 months ago #41691

  • Romero64
  • Romero64's Avatar
  • OFFLINE
  • Junior Boarder
  • Posts: 40
  • Thank you received: 1
I'm doing a simulation for a period of 4 days ( 345600 seconds ) with a previous simulation file of 2 days ( 172800 seconds ).

My liquid boundaries file starts at 172800 seconds and finishes at 514800 seconds.

514800 - 172800 = 342000 < 345600 seconds

But I also got an error. Am I missing something?
The administrator has disabled public write access.

[FEATURE] Add check of time series duration during initialisation 1 year 11 months ago #41692

  • c.coulet
  • c.coulet's Avatar
  • OFFLINE
  • Moderator
  • Posts: 3722
  • Thank you received: 1031
You're doing the right things.
But in the computation procedure, there is an interpolation procedure in time which require an extra time in the liquid boundary file...
Just duplicate the latest value with a time increment and this will work...

Hope this helps
Christophe
The administrator has disabled public write access.
The following user(s) said Thank You: Romero64

[FEATURE] Add check of time series duration during initialisation 1 year 11 months ago #41693

  • Romero64
  • Romero64's Avatar
  • OFFLINE
  • Junior Boarder
  • Posts: 40
  • Thank you received: 1
Got it! Thank you so much! I will do this now.
The administrator has disabled public write access.
Moderators: pham

The open TELEMAC-MASCARET template for Joomla!2.5, the HTML 4 version.