open TELEMAC-MASCARET The mathematically superior suite of solvers

Hello,

I do some modification in the file "flux_hllc.f" by adding the source of topography. and i met an error information which i show in the picture below.
I don't understand well which cause this kind of problem.
somebody has a idea? thank you

Hello,

This is a memory error, it can be any Fortran mistake, so seeing your Fortran implementation is necessary.

With best regards,

Jean-Michel Hervouet

bonjour monsieur,

a memory error. in fact, i need to creat a new variable in flux_hllc.f which should be the same type as the H, U, V.
I did some calculates by using H, then gave the calculate result to my new variable , for exemple, new_variable=0.5*H+abs(H).
How to realise this?
I found the type of H,U,V is vector, so I need to creat a vector type to my new variable in fortran,too?

Thanks

Bonjour !

I did not write this part of the code but flux_hllc.f is a subroutine that deals with variables at a node, not with a vector, creating any vector variable like H, U and V here would spoil the computer time. The problem is where is your new variable? If it is in another subroutine you should transmit it by the arguments, then you have to change the calls to flux_hllc. Posting your Fortran file with modified subroutines would give us an idea of what you need to do...

With best regards,

Jean-Michel Hervouet

Hello sir,

I'm sorry to reply late. I upload here my "hllc" file modified, I added ZF1 and ZF2 for taking consider the topography. And for adding the topography influence to the flux, I created variables DELTAB and DERIVB.

I transformed the file to pdf so that it can be acceptable. I light the parts which I modified, sir

Thank you,

Hello,

I see no obvious mistake though I find strange that you introduce ZFL and ZFR instead of using directly ZF1 and ZF2. The problem must be in the calling subroutines where you modified the calls to flux_hllc to add your 2 arguments ZF1 and ZF2, so we would need to see all your modified Fortran.

With best regards,

Jean-Michel Hervouet

Hello sir,

this is my all files of fortran, I use hllc flux, which call hyd_hllc and which call my final modified file flux_hllc.

I compresse it under linux diretely, if you have some problems to open it or to see it, you tell me, and I transform it to pdf.

Thank you
jie

Hello,

Actually I find that there are other calls to flux_hllc, and all the calls must be changed. You can see that in the doxydocs section of this website: the calling subroutines of flux_hllc.f are:

hyd_hllc, flux_waf, cdl_hllc.

With best regards,

Jean-Michel Hervouet

I need to modify some file of telemac2d, but as a beignner, it's not easy. I want to ask you, for better understanding the telemac2d, its structure, how it fonctionne, what's the relations between different code file. Do you have some suggets or some books, references to recommend, please? That will be very helpful.

thank you,
jie